404 Page handling w/ issue form (#362) #365
Conversation
There was a problem hiding this comment.
Thanks this looks like it's pretty close to what we need. Can you update the text when the results are not provided such that users won't keep making the same mistakes.
It might be that the undetected value should be blank and the text descriptions should be more verbose saying "If this isn't autodetected it means you have to fill it in yourself.
And with the required: true then the form won't submit with the unfilled URLs.
There was a problem hiding this comment.
Sorry looking closer you put the message into the placeholder spot. Which I think will then pass validation because the content is not empty and we'll get a bunch of issues filed with the placeholder text that won't be useful. Instead please update the description to be verbose with the full info that these fields need to be filled in if undetected.
You could potentially add secondary fields which auto populate as to whether the fields were automatically detectable or had to be manually filled out.
I think that something to this effect for both could be clearer.
- Able to detect referrer autocratically if no, please fill in the referrer url below, if yes please verify the url looks correct below: [ yes, no]
- Referrer url: ""
|
Hi @tfoote
Does this align with your expectations? Moreover, it's worth noting that the placeholder text doesn't auto-populate the form. Instead, it functions as a visual cue, presenting text within the input field until users input their own text, which then supersedes the placeholder. Essentially, it serves as a subtle prompt rather than pre-filling the form. Please refer to the image below: the 'Submit New Issue' button remains unavailable until both required fields are properly filled.
|
|
Thanks for the testing on your instance and finding out that the validation works better than I had expected. I'll give it a try with slightly tweaked verbiage. |
|
Thanks @tfoote Based on my experimentation, it appears that the required fields function solely on public repositories. The following quote provides further insight: Prevents form submission until element is completed. Only for public repositories. Should I add the checkboxes ? Thanks |
|
With the placeholders not filling the validation it's not necessary. I found one bug that there's a typo in the referrer key which is missing an |
Fixing referrer url tag string from #365
Fixing referrer url tag string from #365
|
Thank you @tfoote. Thanks! |
This pull request introduces the updateGitHref() function. It is responsible for dynamically updating a GitHub issue link with relevant information.
Referrer URL Handling: It's worth noting that accessing document.referrer might result in an empty value if the user navigated directly to the page or if the browser's privacy settings restrict referrer information. The function handles such scenarios, providing a default value to prevent errors.
Issue: #362 from @tfoote